[asterisk-dev] [Code Review] 2408: Pimp Sip: Video support

[Kevin Harwell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2408/
-----------------------------------------------------------

(Updated March 26, 2013, 7:36 p.m.)


Review request for Asterisk Developers and Joshua Colp.


Changes
-------

Combined similar functionality of audio/video sdp handling into a single file (res_sip_sdp_media.c).  Addressed other review items too.


Bugs: ASTERISK-21077
    https://issues.asterisk.org/jira/browse/ASTERISK-21077


Repository: Asterisk


Description
-------

Adds video media handling support to the new SIP work being done in Asterisk.  Similar to audio added res_sip_sdp_video.c to handle sdp media negotiations for video.  Added capabilities support to make sure the correct codecs were being offered.  Also added the ability to handle the video source update control frame and initiate a fast video update request when needed.


Diffs (updated)
-----

  /team/group/pimp_my_sip/channels/chan_gulp.c 383922 
  /team/group/pimp_my_sip/include/asterisk/res_sip_session.h 383922 
  /team/group/pimp_my_sip/res/res_sip_sdp_audio.c 383922 
  /team/group/pimp_my_sip/res/res_sip_sdp_media.c PRE-CREATION 
  /team/group/pimp_my_sip/res/res_sip_session.c 383922 

Diff: https://reviewboard.asterisk.org/r/2408/diff/


Testing
-------

Using two softphones that support video was able to successfully connect, via asterisk, and view video.  Also monitored sip messages to make sure the appropriate media attributes were being propagated.


Thanks,

Kevin Harwell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130326/2bf05e75/attachment.htm>