[asterisk-dev] [Code Review] Stasis http: Add configuration

Kevin Harwell reviewboard at asterisk.org
Fri Mar 22 17:29:02 CDT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2413/
-----------------------------------------------------------

Review request for Asterisk Developers and David Lee.


Summary
-------

Added some basic configuration to stasis http.  Namely two global options:

enabled - defaults to yes and when set to no, stasis-http support is disabled.
pretty - defaults to no (compact format) otherwise when set to yes, responses from stasis-http are formatted to be human readable.


This addresses bug ASTERISK-21267.
    https://issues.asterisk.org/jira/browse/ASTERISK-21267


Diffs
-----

  /team/dlee/stasis-http/include/asterisk/json.h 383653 
  /team/dlee/stasis-http/res/res_json.c 383653 
  /team/dlee/stasis-http/res/res_stasis_http.c 383653 
  /team/dlee/stasis-http/res/res_stasis_websocket.c 383653 
  /team/dlee/stasis-http/tests/test_json.c 383653 

Diff: https://reviewboard.asterisk.org/r/2413/diff


Testing
-------

Ran asterisk with no options specified in the configuration file and then viewed a response to make sure it was in the appropriate format.  From there added/modified the options in the config file in various combinations and then reloaded or unloaded/loaded the module each time config file was changed and viewed stasis http responses when appropriate.  Also ran a few of the existing relevant unit tests to make sure nothing broke.


Thanks,

Kevin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130322/43dd531a/attachment.htm>


More information about the asterisk-dev mailing list