[asterisk-dev] [Code Review] Clean up Makefile "warning" clutter when makeopts doesn't exist

[wdoekes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2304/
-----------------------------------------------------------

(Updated March 21, 2013, 3:33 p.m.)


Review request for Asterisk Developers and Jason Parker.


Changes
-------

> What do you think about putting the defaults in build_tools/make_version itself?

Ok.

> Or for xmldocs, something like this perhaps?

Ok.


Summary
-------

When there is no makeopts (distclean removes it), we get ugly errors when running make.

$ make
build_tools/make_version: 183: URL: not found
build_tools/make_version: 183: {print $2;}: not found
svn: Write error: Broken pipe
/bin/sh: Illegal option - 
/bin/sh: Illegal option - 
...
****
**** The configure script must be executed before running 'make'.
****               Please run "./configure".
****

Those ugly errors can be avoided in the majority of case by providing defaults for AWK and GREP. That's what this patch does.

This means that you can now run make distclean twice and get output without ugly errors.


P.S. @admins: https://reviewboard.asterisk.org/r/2303/ yields a Django error and is uneditable because I accidentally called qwell "Jason Parker".


Diffs (updated)
-----

  /trunk/Makefile 383540 
  /trunk/build_tools/make_buildopts_h 383540 
  /trunk/build_tools/make_linker_version_script 383540 
  /trunk/build_tools/make_version 383540 
  /trunk/build_tools/mkpkgconfig 383540 

Diff: https://reviewboard.asterisk.org/r/2304/diff


Testing
-------

It works if awk en grep are in your path. If they aren't, the errors will at least be more readable (missing grep instead of "Illegal option").

AWK and GREP will still get overridden by makeopts if it exists, so no loss of functionality there.


Thanks,

wdoekes

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130321/44d8f168/attachment-0001.htm>