[asterisk-dev] [Code Review]: SIP Domain, Registrar, and Outbound Registration support.

[Joshua Colp]

> On March 21, 2013, 1:59 p.m., opticron wrote:
> > /team/group/pimp_my_sip/res/res_sip_outbound_registration.c, lines 109-112
> > <https://reviewboard.asterisk.org/r/2398/diff/1/?file=34741#file34741line109>
> >
> >     Red blobs.

Fixed.


> On March 21, 2013, 1:59 p.m., opticron wrote:
> > /team/group/pimp_my_sip/res/res_sip_outbound_registration.c, lines 196-201
> > <https://reviewboard.asterisk.org/r/2398/diff/1/?file=34741#file34741line196>
> >
> >     String fields need to be cleaned up here.

Fixed.


> On March 21, 2013, 1:59 p.m., opticron wrote:
> > /team/group/pimp_my_sip/res/res_sip_outbound_registration.c, line 286
> > <https://reviewboard.asterisk.org/r/2398/diff/1/?file=34741#file34741line286>
> >
> >     This doesn't need to be an "else if" given the previous block makes this branch mutually exclusive.

Changed.


> On March 21, 2013, 1:59 p.m., opticron wrote:
> > /team/group/pimp_my_sip/res/res_sip_outbound_registration.c, line 303
> > <https://reviewboard.asterisk.org/r/2398/diff/1/?file=34741#file34741line303>
> >
> >     Idem.

Changed.


> On March 21, 2013, 1:59 p.m., opticron wrote:
> > /team/group/pimp_my_sip/res/res_sip_registrar.c, line 180
> > <https://reviewboard.asterisk.org/r/2398/diff/1/?file=34742#file34742line180>
> >
> >     Idem.

Changed.


> On March 21, 2013, 1:59 p.m., opticron wrote:
> > /team/group/pimp_my_sip/res/res_sip_registrar.c, line 184
> > <https://reviewboard.asterisk.org/r/2398/diff/1/?file=34742#file34742line184>
> >
> >     Idem.

Changed.


> On March 21, 2013, 1:59 p.m., opticron wrote:
> > /team/group/pimp_my_sip/res/res_sip_registrar.c, line 221
> > <https://reviewboard.asterisk.org/r/2398/diff/1/?file=34742#file34742line221>
> >
> >     Idem.

Changed.


> On March 21, 2013, 1:59 p.m., opticron wrote:
> > /team/group/pimp_my_sip/res/res_sip_registrar.c, line 237
> > <https://reviewboard.asterisk.org/r/2398/diff/1/?file=34742#file34742line237>
> >
> >     Idem.

Changed.


> On March 21, 2013, 1:59 p.m., opticron wrote:
> > /team/group/pimp_my_sip/res/res_sip_registrar.c, line 253
> > <https://reviewboard.asterisk.org/r/2398/diff/1/?file=34742#file34742line253>
> >
> >     Idem.

Changed.


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2398/#review8115
-----------------------------------------------------------


On March 18, 2013, 7:23 a.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2398/
> -----------------------------------------------------------
> 
> (Updated March 18, 2013, 7:23 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This change adds the following:
> 
> 1. A basic registrar which uses the location API to store/update/delete contacts. It also enforces restrictions as configured on the AOR being registered to.
> 2. Basic outbound registration support.
> 3. Domain support.
> 
> 
> Diffs
> -----
> 
>   /team/group/pimp_my_sip/include/asterisk/res_sip.h 383209 
>   /team/group/pimp_my_sip/res/res_sip/config_domain_aliases.c PRE-CREATION 
>   /team/group/pimp_my_sip/res/res_sip/config_transport.c 383209 
>   /team/group/pimp_my_sip/res/res_sip/location.c 383206 
>   /team/group/pimp_my_sip/res/res_sip/sip_configuration.c 383209 
>   /team/group/pimp_my_sip/res/res_sip_endpoint_identifier_user.c 383206 
>   /team/group/pimp_my_sip/res/res_sip_outbound_registration.c PRE-CREATION 
>   /team/group/pimp_my_sip/res/res_sip_registrar.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/2398/diff
> 
> 
> Testing
> -------
> 
> Tested outbound unauthenticated registrations to remote servers with automatic refresh and failures
> Tested inbound registrations from devices with all provided configuration options
> Tested calling to registered devices
> Tested configured domain aliases
> Tested inbound calling from devices using domains
> 
> 
> Thanks,
> 
> Joshua
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130321/59086392/attachment-0001.htm>