[asterisk-dev] [Code Review] Fix Regression Caused By Adding The Ability To Call StopMixMonitor With An Optional ID

[elguero]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2404/
-----------------------------------------------------------

(Updated March 20, 2013, 12:13 p.m.)


Review request for Asterisk Developers.


Changes
-------

*Added another test report


Summary
-------

The svn commit r352093 for ASTERISK-19096 allowing an optional ID to be used when calling StopMixMonitor, is causing a change in behavior.  When we are unable to stop mixmonitor on a channel, -1 is being returned triggering the channel to hangup.

This patch restores the prior behavior by returning 0 upon success or failure when calling the application StopMixMonitor while at the same time allowing the manager call to stop the mixmonitor to use the return code.


This addresses bug ASTERISK-21294.
    https://issues.asterisk.org/jira/browse/ASTERISK-21294


Diffs
-----

  /branches/11/apps/app_mixmonitor.c 383337 

Diff: https://reviewboard.asterisk.org/r/2404/diff


Testing (updated)
-------

The reporter, daroz, tested this on a production machine today and reported back positive results.

Another user from a downstream issue tracker has tested the patch and reported back that it is working for them.


Thanks,

elguero

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130320/c8b7e315/attachment.htm>