[asterisk-dev] [Code Review] testsuite: when mirroring the asterisk dirs, don't trip over broken symlinks

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2395/#review8093
-----------------------------------------------------------

Ship it!


- Matt


On March 18, 2013, 3:51 a.m., wdoekes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2395/
> -----------------------------------------------------------
> 
> (Updated March 18, 2013, 3:51 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Hi,
> 
> the os.path.exists() check returns False when a broken symlink is read while doing the Asterisk.__mirror_dir creating. Use os.path.lexists() instead.
> 
> Reproduce:
> 
>   place a broken symlink in /var/lib/asterisk and watch all tests fail
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/lib/python/asterisk/asterisk.py 3668 
> 
> Diff: https://reviewboard.asterisk.org/r/2395/diff
> 
> 
> Testing
> -------
> 
> After the patch, the tests don't fail.
> 
> 
> Thanks,
> 
> wdoekes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130320/035e798b/attachment.htm>