[asterisk-dev] [Code Review] func_curl: make it report errors like "server certificate verification failed" instead of returning silently

[wdoekes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2403/
-----------------------------------------------------------

(Updated March 20, 2013, 3:04 a.m.)


Review request for Asterisk Developers.


Changes
-------

Address Tilghman's concerns.


Summary
-------

Failed CURL() requests would be quite silent.

Now you get nice warnings like this:

  WARNING[6701]: func_curl.c:654 acf_curl_helper: server certificate verification failed. \
    CAfile: /etc/ssl/certs/ca-certificates.crt CRLfile: none ('https://ORIGINAL_URL')


Diffs (updated)
-----

  /branches/1.8/funcs/func_curl.c 383308 

Diff: https://reviewboard.asterisk.org/r/2403/diff


Testing
-------

It works.

I also tested that setting CURLOPT_ERRORBUFFER to NULL does what you'd expect. (And the cast is to silent the fancy gcc type checks.)


Thanks,

wdoekes

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130320/2fa00cd2/attachment.htm>