[asterisk-dev] [Code Review] Transition Device State usage to Stasis

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2389/
-----------------------------------------------------------

(Updated March 19, 2013, 8:33 p.m.)


Review request for Asterisk Developers.


Changes
-------

Add unit test.
Take advantage of topic pools and the fact that Stasis unsubscription functions return NULL.
Fix device state publishing not setting the cachability flag.
Move device state aggregator subscription to the cache topic to ensure that the cache is populated properly before the aggregator tries to access it.


Summary
-------

In the move from Asterisk's event system to Stasis, this makes distributed device state aggregation always-on, removes unnecessary task processors where possible, and collapses aggregate and non-aggregate states into a single cache for ease of retrieval. This also removes an intermediary step in device state aggregation.


This addresses bug ASTERISK-21101.
    https://issues.asterisk.org/jira/browse/ASTERISK-21101


Diffs (updated)
-----

  trunk/apps/app_queue.c 383337 
  trunk/include/asterisk/devicestate.h 383337 
  trunk/include/asterisk/xmpp.h 383337 
  trunk/main/asterisk.c 383337 
  trunk/main/ccss.c 383337 
  trunk/main/devicestate.c 383337 
  trunk/main/pbx.c 383337 
  trunk/res/res_jabber.c 383337 
  trunk/res/res_xmpp.c 383337 
  trunk/tests/test_devicestate.c 383337 

Diff: https://reviewboard.asterisk.org/r/2389/diff


Testing
-------

This change was run against the queue integration tests, the generic_ccss test, the device_state_notification test, and the non_digium_state_change test with no ill effects.


Thanks,

opticron

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130320/3739a7ca/attachment-0001.htm>