[asterisk-dev] [Code Review] Transition MWI events to Stasis

[David Lee]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2368/#review8049
-----------------------------------------------------------


Minor complaints; easily fixed. Looks good!


team/dlee/stasis-core/channels/chan_dahdi.c
<https://reviewboard.asterisk.org/r/2368/#comment15451>

    The way stasis caching works, I don't think the no-op subscription is actually necessary.



team/dlee/stasis-core/channels/chan_iax2.c
<https://reviewboard.asterisk.org/r/2368/#comment15452>

    Ditto on the unnecessary comment.



team/dlee/stasis-core/channels/chan_mgcp.c
<https://reviewboard.asterisk.org/r/2368/#comment15453>

    Ditto on the unnecessary comment.



team/dlee/stasis-core/main/app.c
<https://reviewboard.asterisk.org/r/2368/#comment15454>

    The container should be locked to avoid race conditions building two topics at the same time.


- David


On March 7, 2013, 4:05 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2368/
> -----------------------------------------------------------
> 
> (Updated March 7, 2013, 4:05 p.m.)
> 
> 
> Review request for Asterisk Developers and David Lee.
> 
> 
> Summary
> -------
> 
> This converts the usage of the existing event system in Asterisk for MWI to use Stasis as the pubsub backend.
> 
> Note: This patch requires the changes in https://reviewboard.asterisk.org/r/2367/ to compile.
> 
> 
> This addresses bug ASTERISK-21097.
>     https://issues.asterisk.org/jira/browse/ASTERISK-21097
> 
> 
> Diffs
> -----
> 
>   team/dlee/stasis-core/res/res_xmpp.c 382648 
>   team/dlee/stasis-core/main/asterisk.c 382648 
>   team/dlee/stasis-core/res/res_jabber.c 382648 
>   team/dlee/stasis-core/include/asterisk/xmpp.h 382648 
>   team/dlee/stasis-core/main/app.c 382648 
>   team/dlee/stasis-core/channels/sip/include/sip.h 382648 
>   team/dlee/stasis-core/include/asterisk/app.h 382648 
>   team/dlee/stasis-core/channels/chan_unistim.c 382648 
>   team/dlee/stasis-core/channels/sig_pri.h 382648 
>   team/dlee/stasis-core/channels/sig_pri.c 382648 
>   team/dlee/stasis-core/channels/chan_skinny.c 382648 
>   team/dlee/stasis-core/channels/chan_mgcp.c 382648 
>   team/dlee/stasis-core/channels/chan_sip.c 382648 
>   team/dlee/stasis-core/apps/app_minivm.c 382648 
>   team/dlee/stasis-core/apps/app_voicemail.c 382648 
>   team/dlee/stasis-core/channels/chan_dahdi.c 382648 
>   team/dlee/stasis-core/channels/chan_iax2.c 382648 
> 
> Diff: https://reviewboard.asterisk.org/r/2368/diff
> 
> 
> Testing
> -------
> 
> MWI distribution to SIP phones has been tested manually as has the pollmailboxes option for voicemail.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130314/a94525b0/attachment-0001.htm>