[asterisk-dev] [Code Review] Pimp SIP Media generification

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2380/
-----------------------------------------------------------

(Updated March 11, 2013, 10:48 a.m.)


Review request for Asterisk Developers, Mark Michelson and Joshua Colp.


Changes
-------

Updated for some of Josh's comments.


Summary
-------

Abstract media type restrictions out of res_sip_session and move them to chan_gulp where they're actually needed.  Due to the change, the sdp handler callback structure has been modified to accept a ast_sip_session_media struct and had a destroy function added and ast_sip_session_media_position has been removed from res_sip_session.h

This will need updates when Pimp SIP NAT goes in.


This addresses bug ASTERISK-21184.
    https://issues.asterisk.org/jira/browse/ASTERISK-21184


Diffs (updated)
-----

  team/group/pimp_my_sip/channels/chan_gulp.c 382643 
  team/group/pimp_my_sip/include/asterisk/res_sip_session.h 382643 
  team/group/pimp_my_sip/res/res_sip_sdp_audio.c 382643 
  team/group/pimp_my_sip/res/res_sip_session.c 382643 

Diff: https://reviewboard.asterisk.org/r/2380/diff


Testing
-------

Tested with call scenarios from SDP_offer_answer integration test using a quickly hacked together video sdp handler which may or may not work properly but responds like it should (cp res/res_sip_sdp_audio.c res/res_sip_sdp_video.c;sed -i 's/AUDIO/VIDEO/;s/audio/video/' res/res_sip_sdp_video.c)


Thanks,

opticron

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130311/63615c6f/attachment.htm>