[asterisk-dev] [Code Review] Initial stasis-core message bus

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2339/#review8010
-----------------------------------------------------------

Ship it!


Having now run this through valgrind umpteen times and double-checked the vast-majority of the code, I'd say what is currently in the stasis-core branch is ready to go.

- opticron


On March 6, 2013, 1:27 p.m., David Lee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2339/
> -----------------------------------------------------------
> 
> (Updated March 6, 2013, 1:27 p.m.)
> 
> 
> Review request for Asterisk Developers, Matt Jordan and kmoore.
> 
> 
> Summary
> -------
> 
> This patch adds a new message bus API to Asterisk.
> 
> For the initial use of this bus, I took some work kmoore did creating
> channel snapshots. So rather than create AMI events directly in the
> channel code, this patch generates Stasis events, which manager.c uses
> to then publish the AMI event.
> 
> This message bus provides a generic publish/subscribe mechanism within
> Asterisk. This message bus is:
> 
>  - Loosely coupled; new message types can be added in seperate modules.
>  - Easy to use; publishing and subscribing are straightforward
>    operations.
>  - Consistent memory management; all message bus objects are AO2
>    managed objects, using ao2_ref() and ao2_cleanup() to manage the
>    reference counting.
> 
> In addition to basic publish/subscribe, the patch also provides a
> mechanisms for message forwarding, and for message caching.
> 
> 
> This addresses bug ASTERISK-20959.
>     https://issues.asterisk.org/jira/browse/ASTERISK-20959
> 
> 
> Diffs
> -----
> 
>   /trunk/tests/test_stasis.c PRE-CREATION 
>   /trunk/main/stasis_message.c PRE-CREATION 
>   /trunk/main/stasis_cache.c PRE-CREATION 
>   /trunk/main/pbx.c 382490 
>   /trunk/main/stasis.c PRE-CREATION 
>   /trunk/main/manager.c 382490 
>   /trunk/main/channel_internal_api.c 382490 
>   /trunk/main/asterisk.c 382490 
>   /trunk/main/asterisk.exports.in 382490 
>   /trunk/main/channel.c 382490 
>   /trunk/include/asterisk/channel_internal.h 382490 
>   /trunk/include/asterisk/stasis.h PRE-CREATION 
>   /trunk/include/asterisk/channel.h 382490 
> 
> Diff: https://reviewboard.asterisk.org/r/2339/diff
> 
> 
> Testing
> -------
> 
> Unit tests; manually verified AMI events for a few calls.
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130307/d5adfb5b/attachment.htm>