[asterisk-dev] [Code Review] Refactor cdr to use configuration framework; provide configuration documentation

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2372/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

This patch refactors the CDR engine to use the configuration framework. The patch also provides documentation for the CDR configuration parameters. This makes the loading of the configuration atomic, which reduces some of the shenanigans that can happen with a bad configuration file.


This addresses bug ASTERISK-21196.
    https://issues.asterisk.org/jira/browse/ASTERISK-21196


Diffs
-----

  trunk/main/cdr.c 382407 

Diff: https://reviewboard.asterisk.org/r/2372/diff


Testing
-------

Ran the CDR test suite tests. Verified that they still ran.

Loaded Asterisk:
 * Without a cdr.conf
 * With a bad cdr.conf
 * With a good cdr.conf that disabled CDRs
 * With a good cdr.conf that enabled CDRs but disabled batch mode
 * With a good cdr.conf that enabled CDRs and enabled batch mode

Performed reloads:
 * That disabled a previously enabled CDR engine
 * That enabled a previously disabled CDR engine
 * That enabled CDRs and batch mode when it previously ran in simple mode
 * That enabled CDRs and disabled batch mode when it previously ran in batch mode


Thanks,

Matt

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130307/9e1611f3/attachment.htm>