[asterisk-dev] [Code Review]: Add to Stasis subscription change notices and message cache dumping

[opticron]

> On March 4, 2013, 1:46 p.m., David Lee wrote:
> > team/dlee/stasis-core/main/stasis.c, line 195
> > <https://reviewboard.asterisk.org/r/2367/diff/2/?file=33762#file33762line195>
> >
> >     This can still be problematic, since the unsubscribe can happen within the topic's dtor. The ao2_ref will erroneously increment the topic's refcount back to 1, and the sub will have a bad pointer to the topic, which it will try to re-delete when its refcount goes to 0.

This is now fixed in stasis-core.


- opticron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2367/#review7983
-----------------------------------------------------------


On March 4, 2013, 1:27 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2367/
> -----------------------------------------------------------
> 
> (Updated March 4, 2013, 1:27 p.m.)
> 
> 
> Review request for Asterisk Developers and David Lee.
> 
> 
> Summary
> -------
> 
> This review covers several items involved in the transition of MWI from the event system to Stasis:
> * Creation of cache dump capability (necessary for pollmailboxes in app_voicemail)
> * Addition of subscription change notices (necessary for pollmailboxes in app_voicemail)
> * Update of the Stasis unit tests to cover those new items
> * Ability to set a server EID on messages
> 
> 
> This addresses bug ASTERISK-21097.
>     https://issues.asterisk.org/jira/browse/ASTERISK-21097
> 
> 
> Diffs
> -----
> 
>   team/dlee/stasis-core/include/asterisk/stasis.h 382383 
>   team/dlee/stasis-core/main/stasis.c 382383 
>   team/dlee/stasis-core/main/stasis_cache.c 382383 
>   team/dlee/stasis-core/main/stasis_message.c 382383 
>   team/dlee/stasis-core/tests/test_stasis.c 382383 
> 
> Diff: https://reviewboard.asterisk.org/r/2367/diff
> 
> 
> Testing
> -------
> 
> Tested this using the unit tests and in conjunction with the MWI changes they were created for.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130306/dc2e2250/attachment.htm>