[asterisk-dev] [Code Review] Pimp SIP Nat

Joshua Colp reviewboard at asterisk.org
Wed Mar 6 06:04:36 CST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2363/
-----------------------------------------------------------

(Updated March 6, 2013, 6:04 a.m.)


Review request for Asterisk Developers.


Changes
-------

Incorporated feedback from Mark.


Summary
-------

This change adds a new module, res_sip_nat, which performs rewriting of outgoing messages for cases where address information needs to be replaced when Asterisk is behind NAT. It also performs rewriting of incoming messages for cases where the remote party may be behind NAT. This change also adds ICE support.


Diffs (updated)
-----

  /team/group/pimp_my_sip/include/asterisk/res_sip.h 382479 
  /team/group/pimp_my_sip/include/asterisk/res_sip_session.h 382479 
  /team/group/pimp_my_sip/res/res_sip/config_transport.c 382479 
  /team/group/pimp_my_sip/res/res_sip/sip_configuration.c 382479 
  /team/group/pimp_my_sip/res/res_sip/sip_distributor.c 382479 
  /team/group/pimp_my_sip/res/res_sip_nat.c PRE-CREATION 
  /team/group/pimp_my_sip/res/res_sip_sdp_audio.c 382479 
  /team/group/pimp_my_sip/res/res_sip_session.c 382479 

Diff: https://reviewboard.asterisk.org/r/2363/diff


Testing
-------

Tested Asterisk behind NAT with proper configuration, as well as devices behind NAT. Also tested ICE negotiation.


Thanks,

Joshua

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130306/b7fa0496/attachment.htm>


More information about the asterisk-dev mailing list