[asterisk-dev] [Code Review] Testsuite: Disallow MoH upon hold option

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2337/#review7980
-----------------------------------------------------------



/asterisk/trunk/tests/channels/SIP/sip_hold_no_moh/sipp/phone_A.xml
<https://reviewboard.asterisk.org/r/2337/#comment15152>

    Remove items from Allow: lines that have no relevance to the test.  If support for these is added in the future or is available in an alternative channel driver, they could cause the test to fail.



/asterisk/trunk/tests/channels/SIP/sip_hold_no_moh/sipp/phone_A.xml
<https://reviewboard.asterisk.org/r/2337/#comment15153>

    Idem.



/asterisk/trunk/tests/channels/SIP/sip_hold_no_moh/sipp/phone_A.xml
<https://reviewboard.asterisk.org/r/2337/#comment15154>

    Idem.



/asterisk/trunk/tests/channels/SIP/sip_hold_no_moh/sipp/phone_B.xml
<https://reviewboard.asterisk.org/r/2337/#comment15155>

    Idem.



/asterisk/trunk/tests/channels/SIP/sip_hold_no_moh/sipp/phone_B.xml
<https://reviewboard.asterisk.org/r/2337/#comment15156>

    Idem.



/asterisk/trunk/tests/channels/SIP/sip_hold_no_moh/sipp/phone_B.xml
<https://reviewboard.asterisk.org/r/2337/#comment15157>

    Idem.


- opticron


On March 1, 2013, 3:49 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2337/
> -----------------------------------------------------------
> 
> (Updated March 1, 2013, 3:49 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Tests to make sure the music on hold event is not triggered if the "discard_remote_hold_retrieval" option is set to "yes".  In the test multiple scenarios are ran where one SIP phone puts another SIP phone on hold by sending a re-INVITE with a modified SDP containing either a restricted audio direction, an IP address of 0.0.0.0, or a combination thereof.  This is tested both for a local RTP bridge, and a non-bridged scenario.
> 
> 
> This addresses bug ABE-2899.
>     https://issues.asterisk.org/jira/browse/ABE-2899
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/channels/SIP/tests.yaml 3642 
>   /asterisk/trunk/tests/channels/SIP/sip_hold_no_moh/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_hold_no_moh/sipp/phone_B.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_hold_no_moh/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_hold_no_moh/sipp/phone_A.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_hold_no_moh/configs/ast1/extensions.conf PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/2337/diff
> 
> 
> Testing
> -------
> 
> Ran the test and made sure all scenarios passed.  Also set the discard_remote_hold_retrieval to "no" and made sure the test failed. 
> 
> 
> Thanks,
> 
> Kevin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130304/5f66f983/attachment.htm>