[asterisk-dev] [Code Review] 2627: Refactor extraneous channel events

Joshua Colp reviewboard at asterisk.org
Fri Jun 28 09:13:43 CDT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2627/#review9005
-----------------------------------------------------------

Ship it!


Ship It!


trunk/channels/sig_analog.c
<https://reviewboard.asterisk.org/r/2627/#comment17707>

    Not actually an alarm...


- Joshua Colp


On June 25, 2013, 7:11 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2627/
> -----------------------------------------------------------
> 
> (Updated June 25, 2013, 7:11 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21476
>     https://issues.asterisk.org/jira/browse/ASTERISK-21476
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This change removes JitterBufStats and ChannelReload and refactors the following events to travel over Stasis-Core:
> * LocalBridge
> * DAHDIChannel
> * AlarmClear
> * SpanAlarmClear
> * Alarm
> * SpanAlarm
> * DNDState
> * MCID
> * ChannelUpdate
> * SIPQualifyPeerDone
> * SessionTimeout
> 
> 
> Diffs
> -----
> 
>   trunk/CHANGES 392859 
>   trunk/apps/app_meetme.c 392859 
>   trunk/apps/app_queue.c 392859 
>   trunk/channels/chan_dahdi.c 392859 
>   trunk/channels/chan_gtalk.c 392859 
>   trunk/channels/chan_iax2.c 392859 
>   trunk/channels/chan_sip.c 392859 
>   trunk/channels/sig_analog.c 392859 
>   trunk/channels/sig_pri.c 392859 
>   trunk/channels/sip/include/sip.h 392859 
>   trunk/configs/sip.conf.sample 392859 
>   trunk/include/asterisk/json.h 392859 
>   trunk/include/asterisk/stasis.h 392859 
>   trunk/main/core_local.c 392859 
>   trunk/main/json.c 392859 
>   trunk/res/res_agi.c 392859 
> 
> Diff: https://reviewboard.asterisk.org/r/2627/diff/
> 
> 
> Testing
> -------
> 
> Manual testing.  Automated tests coming for some.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130628/5287e229/attachment.htm>


More information about the asterisk-dev mailing list