[asterisk-dev] [Code Review] 2643: Stasis - Refactor AOC Events

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2643/#review8999
-----------------------------------------------------------



./trunk/main/aoc.c
<https://reviewboard.asterisk.org/r/2643/#comment17702>

    This looks very similar to a piece of code in ast_manager_str_from_json_object() in manager.c. As such, this should probably be located in manager.c as well so that ast_manager_str_from_json_object() can use it instead of duplicating this code.



./trunk/main/aoc.c
<https://reviewboard.asterisk.org/r/2643/#comment17703>

    Where is the documentation for these AMI events?


- opticron


On June 25, 2013, 2:15 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2643/
> -----------------------------------------------------------
> 
> (Updated June 25, 2013, 2:15 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21472
>     https://issues.asterisk.org/jira/browse/ASTERISK-21472
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Refactored the AMI events in AOC onto Stasis-Core.  The ast_aoc_manager_event function now publishes a channel snapshot, along with a JSON blob describing the advice of charge.  A "to_ami" handler has also been added that converts the channel snapshot and AOC event data back into the appropriate data structure for use with AMI.
> 
> 
> Diffs
> -----
> 
>   ./trunk/main/aoc.c 392862 
> 
> Diff: https://reviewboard.asterisk.org/r/2643/diff/
> 
> 
> Testing
> -------
> 
> This one is kind of hard to actually test.  However, I did create a temporary AMI command in order to push data into the ast_aoc_manager_event function in order to verify the values were properly being converted between data structures, JSON, and string values.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130627/bc8dbec9/attachment-0001.htm>