[asterisk-dev] [Code Review] 2623: New SIP Channel Driver - Add CLI/AMI initiated NOTIFY requests

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2623/#review8995
-----------------------------------------------------------

Ship it!


Ship It!


./trunk/include/asterisk/res_sip.h
<https://reviewboard.asterisk.org/r/2623/#comment17687>

    This would be better written as:
    
    "Retrieve any endpoints currently available to sorcery."



./trunk/include/asterisk/res_sip.h
<https://reviewboard.asterisk.org/r/2623/#comment17689>

    Still not quite true ;)
    
    "Retrieve any endpoints available to sorcery." is better



./trunk/res/res_sip_notify.c
<https://reviewboard.asterisk.org/r/2623/#comment17690>

    You can optimize this using the approach struct ast_variable does - allocate all the memory you need with the object and divvy it up.



./trunk/res/res_sip_notify.c
<https://reviewboard.asterisk.org/r/2623/#comment17691>

    Same here - you can use a zero sized array and allocate the space you need with the object.


- Joshua Colp


On June 24, 2013, 10:22 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2623/
> -----------------------------------------------------------
> 
> (Updated June 24, 2013, 10:22 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21436
>     https://issues.asterisk.org/jira/browse/ASTERISK-21436
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Added the ability to send unsolicited NOTIFY requests to a particular endpoint with a configured payload.  Added both CLI and AMI support.  For a given endpoint, this module will iterate over all its contacts sending the appropriate NOTIFY request to each.
> 
> 
> Diffs
> -----
> 
>   ./trunk/res/res_sip_notify.c PRE-CREATION 
>   ./trunk/res/res_sip/sip_options.c 392784 
>   ./trunk/res/res_sip/sip_configuration.c 392784 
>   ./trunk/res/res_sip/include/res_sip_private.h 392784 
>   ./trunk/res/res_sip.exports.in 392784 
>   ./trunk/include/asterisk/res_sip.h 392784 
> 
> Diff: https://reviewboard.asterisk.org/r/2623/diff/
> 
> 
> Testing
> -------
> 
> From the CLI issued the command to send a NOTIFY request to an endpoint with payload data that had been configured in sip_notify.conf.  Also connected via AMI and initiated an action to send a NOTIFY request to an endpoint with a given event type.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130627/5fa19c54/attachment.htm>