[asterisk-dev] [Code Review] 2634: Implement ARI /channels dial.

[Matt Jordan]

> On June 24, 2013, 10:09 p.m., Matt Jordan wrote:
> > Just to double check, what happens to the called channel if the caller hangs up? Does it remain in Stasis, or is it automatically hung up as well?
> 
> Jason Parker wrote:
>     The called channel was never in Stasis.  It gets hung up.

This may be okay for now, but I can see someone wanting the ability to 'own' the called channel from a Stasis application.

Here's one use case.

* Caller calls in and gets bridged with an Agent's channel
* Caller accidentally hangs up
* Agent presses some DTMF key (or a widget on a UI) that says "hey, they weren't supposed to hang up yet, dial them back" (they may have asked for the person's number so they can dial them back if disconnected, etc.)
* We perform a Dial from the Agent to the caller's resource/tech
* Agent decides they want to pass the called channel (who was the caller) to another Agent

Since Stasis doesn't 'own' the channel, I'm not sure we can remove that channel from the bridge and pass it off to another bridge in Stasis. An attempt to do so will probably result in the REST API coming back with a 'you don't own this' error.

I suspect that isn't what people would want.


- Matt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2634/#review8956
-----------------------------------------------------------


On June 25, 2013, 6:58 p.m., Jason Parker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2634/
> -----------------------------------------------------------
> 
> (Updated June 25, 2013, 6:58 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21620
>     https://issues.asterisk.org/jira/browse/ASTERISK-21620
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Implement the dial action on channels.  This creates a new outbound leg, which upon answer, gets bridged with an existing channel sitting in Stasis.
> 
> 
> Diffs
> -----
> 
>   /trunk/res/stasis/control.c 392855 
>   /trunk/include/asterisk/stasis_app.h 392855 
>   /trunk/res/res_stasis_http_channels.c 392855 
>   /trunk/rest-api/api-docs/channels.json 392855 
>   /trunk/res/stasis_http/resource_channels.h 392855 
>   /trunk/res/stasis_http/resource_channels.c 392855 
> 
> Diff: https://reviewboard.asterisk.org/r/2634/diff/
> 
> 
> Testing
> -------
> 
> The bridge gets created.  The channels can talk to each other.  The bridge disappears once the caller hangs up.  The caller remains in Stasis and can still be acted upon.
> 
> 
> Thanks,
> 
> Jason Parker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130625/9eea5982/attachment.htm>