[asterisk-dev] [Code Review] 2635: CEL refactoring cleanup

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2635/#review8962
-----------------------------------------------------------

Ship it!



trunk/main/cel.c
<https://reviewboard.asterisk.org/r/2635/#comment17639>

    This indentation looks a tad weird.
    
    I suspect that you'll need a default: case in here as well, even if that case only logs an error.


- Matt Jordan


On June 20, 2013, 4:14 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2635/
> -----------------------------------------------------------
> 
> (Updated June 20, 2013, 4:14 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21566
>     https://issues.asterisk.org/jira/browse/ASTERISK-21566
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This change removes AST_CEL_BRIDGE_UPDATE since it should no longer be used because masquerade situations are now accounted for in other ways.
> 
> This also refactors usage of AST_CEL_FORWARD to be produced by a Dial message which has been extended with a "forward" field.
> 
> 
> Diffs
> -----
> 
>   trunk/apps/app_celgenuserevent.c 392313 
>   trunk/apps/app_dial.c 392313 
>   trunk/apps/app_queue.c 392313 
>   trunk/include/asterisk/cel.h 392313 
>   trunk/include/asterisk/stasis_channels.h 392313 
>   trunk/main/cel.c 392313 
>   trunk/main/stasis_channels.c 392313 
> 
> Diff: https://reviewboard.asterisk.org/r/2635/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130625/e04cae8a/attachment.htm>