[asterisk-dev] [Code Review] 2634: Implement ARI /channels dial.

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2634/#review8956
-----------------------------------------------------------


Just to double check, what happens to the called channel if the caller hangs up? Does it remain in Stasis, or is it automatically hung up as well?


/trunk/res/res_stasis_http_channels.c
<https://reviewboard.asterisk.org/r/2634/#comment17622>

    I know this is autogenerated, but...
    
    A user can pass in a negative timeout. Luckily, the dial API will just ignore it if that occurs, but it would be nice if this generated code actually used sscanf.
    
    If it isn't too hard to put that into whatever is generating this to validate the input, that would be a nice addition.



/trunk/res/stasis_http/resource_channels.c
<https://reviewboard.asterisk.org/r/2634/#comment17624>

    Check allocation failure and send a 500 if it fails


- Matt Jordan


On June 20, 2013, 5:53 p.m., Jason Parker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2634/
> -----------------------------------------------------------
> 
> (Updated June 20, 2013, 5:53 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21620
>     https://issues.asterisk.org/jira/browse/ASTERISK-21620
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Implement the dial action on channels.  This creates a new outbound leg, which upon answer, gets bridged with an existing channel sitting in Stasis.
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/stasis_app.h 392345 
>   /trunk/res/res_stasis_http_channels.c 392345 
>   /trunk/res/stasis/control.c 392345 
>   /trunk/res/stasis_http/resource_channels.h 392345 
>   /trunk/res/stasis_http/resource_channels.c 392345 
>   /trunk/rest-api/api-docs/channels.json 392345 
> 
> Diff: https://reviewboard.asterisk.org/r/2634/diff/
> 
> 
> Testing
> -------
> 
> The bridge gets created.  The channels can talk to each other.  The bridge disappears once the caller hangs up.  The caller remains in Stasis and can still be acted upon.
> 
> 
> Thanks,
> 
> Jason Parker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130624/b982bd9f/attachment.htm>