[asterisk-dev] [Code Review] 2588: features: call pickup stasis refactoring

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2588/#review8950
-----------------------------------------------------------



/trunk/main/features.c
<https://reviewboard.asterisk.org/r/2588/#comment17609>

    Replace this with a .to_ami callback



/trunk/main/features.c
<https://reviewboard.asterisk.org/r/2588/#comment17606>

    AMI events have to be raised by the message router in manager. Otherwise, those events will not be ordered with respect to other events raised by manager.
    
    Rather than implementing a callback function, you should instead provide a to_ami/to_json handler for the Pickup event, and let manager raise the event by calling the handler off of the message type.



/trunk/main/features.c
<https://reviewboard.asterisk.org/r/2588/#comment17608>

    With the loss of the message router, you could just initialize the message type here directly.



/trunk/main/features.c
<https://reviewboard.asterisk.org/r/2588/#comment17607>

    There's already a shutdown callback for this file. In general, there's no need to have multiple shutdown callbacks.


- Matt Jordan


On June 5, 2013, 4:08 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2588/
> -----------------------------------------------------------
> 
> (Updated June 5, 2013, 4:08 p.m.)
> 
> 
> Review request for Asterisk Developers, kmoore, Matt Jordan, and rmudgett.
> 
> 
> Bugs: ASTERISK-21544
>     https://issues.asterisk.org/jira/browse/ASTERISK-21544
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> I verified that all the changes to bridging didn't break pickupexten and pickupfailsound since they had nothing to do with that. pickupsound is currently broken and this patch doesn't address that since Richard's https://reviewboard.asterisk.org/r/2582/ fixes that.
> 
> This patch provides a message type sent out to the channel's topic when performing the pickup. The pickup AMI event is now sent out in response to this message type.
> 
> The fields for the AMI event are still compatible with what they were before. It just adds the rest of the channel snapshot information for the Channel and TargetChannel.
> 
> I think the masquerade being performed here already isn't doing anything to inform stasis core that it's happening and there aren't any changes needed there. If I'm wrong on that, feel free to assail me with wassail.
> 
> I still need to write Testsuite tests for call pickup, so that's coming next.
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/features.h 390315 
>   /trunk/main/features.c 390315 
> 
> Diff: https://reviewboard.asterisk.org/r/2588/diff/
> 
> 
> Testing
> -------
> 
> Made sure everything pickup still works or is fixed by other stuff.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130624/1b6714ae/attachment-0001.htm>