[asterisk-dev] [Code Review] 2621: Shuffle RESTful URL's around

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2621/#review8927
-----------------------------------------------------------



/trunk/res/res_http_websocket.c
<https://reviewboard.asterisk.org/r/2621/#comment17564>

    This can be replaced with "ao2_callback(server->protocols, OBJ_NOLOCK, NULL, NULL)".



/trunk/res/res_stasis_http.c
<https://reviewboard.asterisk.org/r/2621/#comment17565>

    Extra line.



/trunk/res/res_stasis_http_asterisk.c
<https://reviewboard.asterisk.org/r/2621/#comment17566>

    One letter variables that are not loop counters are bad.



/trunk/res/res_stasis_http_bridges.c
<https://reviewboard.asterisk.org/r/2621/#comment17567>

    Idem.



/trunk/res/res_stasis_http_channels.c
<https://reviewboard.asterisk.org/r/2621/#comment17568>

    Idem.



/trunk/res/res_stasis_http_endpoints.c
<https://reviewboard.asterisk.org/r/2621/#comment17569>

    Idem.



/trunk/res/res_stasis_http_events.c
<https://reviewboard.asterisk.org/r/2621/#comment17570>

    Idem.



/trunk/res/res_stasis_http_playback.c
<https://reviewboard.asterisk.org/r/2621/#comment17571>

    And idem through the remainder of the changes.


- opticron


On June 13, 2013, 11:52 p.m., David Lee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2621/
> -----------------------------------------------------------
> 
> (Updated June 13, 2013, 11:52 p.m.)
> 
> 
> Review request for Asterisk Developers and Joshua Colp.
> 
> 
> Bugs: ASTERISK-21857
>     https://issues.asterisk.org/jira/browse/ASTERISK-21857
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This patch moves the RESTful URL's around to more appropriate
> locations for release.
> 
> The /stasis URL's are moved to /ari, since Asterisk RESTful Interface
> was a more appropriate name than Stasis-HTTP. (Most of the code still
> has stasis_http references, but they will be cleaned up after there
> are no more outstanding branches that would have merge conflicts with
> such a change).
> 
> A larger change was moving the ARI events WebSocket off of the shared
> /ws URL to its permanent home on /ari/events. The Swagger code
> generator was extended to handle "upgrade: websocket" and
> "websocketProtocol:" attributes on an operation.
> 
> The WebSocket module was modified to better handle WebSocket servers
> that have a single registered protocol handler. If a client
> connections does not specify the Sec-WebSocket-Protocol header, and
> the server has a single protocol handler registered, the WebSocket
> server will go ahead and accept the client for that subprotocol.
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/stasis_http.h 391766 
>   /trunk/res/Makefile 391766 
>   /trunk/res/res_http_websocket.c 391766 
>   /trunk/res/res_http_websocket.exports.in 391766 
>   /trunk/res/res_stasis_http.c 391766 
>   /trunk/res/res_stasis_http.exports.in 391766 
>   /trunk/res/res_stasis_http_asterisk.c 391766 
>   /trunk/res/res_stasis_http_bridges.c 391766 
>   /trunk/res/res_stasis_http_channels.c 391766 
>   /trunk/res/res_stasis_http_endpoints.c 391766 
>   /trunk/res/res_stasis_http_events.c 391766 
>   /trunk/res/res_stasis_http_playback.c 391766 
>   /trunk/res/res_stasis_http_recordings.c 391766 
>   /trunk/res/res_stasis_http_sounds.c 391766 
>   /trunk/res/res_stasis_websocket.c 391766 
>   /trunk/res/stasis_http/ari_websockets.c PRE-CREATION 
>   /trunk/res/stasis_http/resource_events.h 391766 
>   /trunk/res/stasis_http/resource_events.c 391766 
>   /trunk/rest-api-templates/asterisk_processor.py 391766 
>   /trunk/rest-api-templates/param_parsing.mustache PRE-CREATION 
>   /trunk/rest-api-templates/res_stasis_http_resource.c.mustache 391766 
>   /trunk/rest-api-templates/rest_handler.mustache 391766 
>   /trunk/rest-api-templates/stasis_http_resource.c.mustache 391766 
>   /trunk/rest-api-templates/stasis_http_resource.h.mustache 391766 
>   /trunk/rest-api-templates/swagger_model.py 391766 
>   /trunk/rest-api/api-docs/events.json 391766 
>   /trunk/tests/test_stasis_http.c 391766 
> 
> Diff: https://reviewboard.asterisk.org/r/2621/diff/
> 
> 
> Testing
> -------
> 
> * Ran some ARI tests against /ari/events
>   * Specifying the 'ari' subprotocol
>   * Specifying no subprotocol
>   * Specifying any other subprotocol got a 400 response
> * Verified that connecting to /ws echo subprotocol still worked
> 
> 
> Thanks,
> 
> David Lee
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130620/8690af92/attachment-0001.htm>