[asterisk-dev] [Code Review] 2623: New SIP Channel Driver - Add CLI/AMI initiated NOTIFY requests

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2623/#review8922
-----------------------------------------------------------


I didn't find much that Josh didn't already comment on. He's definitely right that this needs to be using the config framework (provided in config_options.h) instead of manipulating config files directly. You can look at apps/app_skel.c for a fictitious example of the config framework in use, or you can look at apps/confbridge/conf_config_parser.c, main/named_acl.c, or main/features_config.c for real-world examples.


./trunk/res/res_sip_notify.c
<https://reviewboard.asterisk.org/r/2623/#comment17544>

    Use ast_cli() here.


- Mark Michelson


On June 14, 2013, 4:05 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2623/
> -----------------------------------------------------------
> 
> (Updated June 14, 2013, 4:05 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21436
>     https://issues.asterisk.org/jira/browse/ASTERISK-21436
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Added the ability to send unsolicited NOTIFY requests to a particular endpoint with a configured payload.  Added both CLI and AMI support.  For a given endpoint, this module will iterate over all its contacts sending the appropriate NOTIFY request to each.
> 
> 
> Diffs
> -----
> 
>   ./trunk/res/res_sip_notify.c PRE-CREATION 
>   ./trunk/res/res_sip/sip_options.c 391775 
>   ./trunk/res/res_sip/sip_configuration.c 391775 
>   ./trunk/res/res_sip/include/res_sip_private.h 391775 
>   ./trunk/res/res_sip.exports.in 391775 
>   ./trunk/include/asterisk/res_sip.h 391775 
> 
> Diff: https://reviewboard.asterisk.org/r/2623/diff/
> 
> 
> Testing
> -------
> 
> From the CLI issued the command to send a NOTIFY request to an endpoint with payload data that had been configured in sip_notify.conf.  Also connected via AMI and initiated an action to send a NOTIFY request to an endpoint with a given event type.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130620/74a0c312/attachment.htm>