[asterisk-dev] [Code Review] 2612: REST API - channel recording support

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2612/#review8918
-----------------------------------------------------------



/trunk/include/asterisk/channel.h
<https://reviewboard.asterisk.org/r/2612/#comment17529>

    Red



/trunk/include/asterisk/file.h
<https://reviewboard.asterisk.org/r/2612/#comment17531>

    A few points here.
    
    1) The function name should not include the word 'sound'. Technically we can stream video as well.
    
    2) file.c and the stream functions contained therein are a lower level than constructs that manipulate said streams. Traditionally, these functions have gone in app.h/app.c, i.e., ast_control_streamfile, etc. If we need this wrapper, this should really go in there.



/trunk/main/channel.c
<https://reviewboard.asterisk.org/r/2612/#comment17532>

    Why wouldn't we allocate the janitor as an ao2 object and just have it be ref counted?



/trunk/main/file.c
<https://reviewboard.asterisk.org/r/2612/#comment17530>

    I'm pretty sure "beep" shouldn't be played regardless of the filename passed in



/trunk/res/res_stasis_recording.c
<https://reviewboard.asterisk.org/r/2612/#comment17533>

    Why re-implement ast_play_and_record?


- Matt Jordan


On June 10, 2013, 7:17 p.m., David Lee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2612/
> -----------------------------------------------------------
> 
> (Updated June 10, 2013, 7:17 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21594
>     https://issues.asterisk.org/jira/browse/ASTERISK-21594
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This patch is the first step in adding recording support to the
> Asterisk REST Interface.
> 
> Recordings are stored in /var/spool/recording. Since recordings may be
> destructive (overwriting existing files), the API rejects attempts to
> escape the recording directory (avoiding issues if someone attempts to
> record to ../../lib/sounds/greeting, for example).
> 
> 
> Diffs
> -----
> 
>   /trunk/res/res_stasis_http_channels.c 391291 
>   /trunk/res/res_stasis_http_bridges.c 391291 
>   /trunk/main/utils.c 391291 
>   /trunk/main/file.c 391291 
>   /trunk/main/channel.c 391291 
>   /trunk/main/asterisk.c 391291 
>   /trunk/include/asterisk/utils.h 391291 
>   /trunk/include/asterisk/stasis_app_recording.h PRE-CREATION 
>   /trunk/include/asterisk/paths.h 391291 
>   /trunk/include/asterisk/file.h 391291 
>   /trunk/include/asterisk/channel.h 391291 
>   /trunk/Makefile 391291 
>   /trunk/res/res_stasis_http_recordings.c 391291 
>   /trunk/res/res_stasis_playback.c 391291 
>   /trunk/res/res_stasis_recording.c PRE-CREATION 
>   /trunk/res/res_stasis_recording.exports.in PRE-CREATION 
>   /trunk/res/stasis_http/resource_channels.h 391291 
>   /trunk/res/stasis_http/resource_channels.c 391291 
>   /trunk/res/stasis_http/resource_recordings.h 391291 
>   /trunk/res/stasis_http/resource_recordings.c 391291 
>   /trunk/rest-api-templates/asterisk_processor.py 391291 
>   /trunk/rest-api-templates/swagger_model.py 391291 
>   /trunk/rest-api/api-docs/channels.json 391291 
>   /trunk/rest-api/api-docs/recordings.json 391291 
>   /trunk/tests/test_utils.c 391291 
> 
> Diff: https://reviewboard.asterisk.org/r/2612/diff/
> 
> 
> Testing
> -------
> 
> Unit tests; swagger-ui for manual testing
> 
> 
> Thanks,
> 
> David Lee
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130619/897d0e86/attachment-0001.htm>