[asterisk-dev] [Code Review] 2632: Pull CEL linkedid manipulation into cel.c
Matt Jordan
reviewboard at asterisk.org
Tue Jun 18 14:58:56 CDT 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2632/#review8913
-----------------------------------------------------------
Ship it!
trunk/main/cel.c
<https://reviewboard.asterisk.org/r/2632/#comment17520>
In the great CDR patch of 2013, the generation of a linkedid is now part of channel allocation. Just as a channel should always have a uniqueid, it should always have a linkedid (which is the uniqueid initially)
This could probably just be an assert.
- Matt Jordan
On June 18, 2013, 7:38 p.m., opticron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2632/
> -----------------------------------------------------------
>
> (Updated June 18, 2013, 7:38 p.m.)
>
>
> Review request for Asterisk Developers.
>
>
> Repository: Asterisk
>
>
> Description
> -------
>
> This finishes moving all CEL linkedid tracking entirely within cel.c since that is now possible with channel snapshots.
>
> This also removes another CEL linkedid manipulation function from cel.h that has already been internalized and is neither called nor available to link against.
>
>
> Diffs
> -----
>
> trunk/include/asterisk/cel.h 391855
> trunk/main/cel.c 391855
> trunk/main/channel.c 391855
>
> Diff: https://reviewboard.asterisk.org/r/2632/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> opticron
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130618/96b1f5aa/attachment.htm>
More information about the asterisk-dev
mailing list