[asterisk-dev] [Code Review] 2628: func_channel: Add a function for reading/writing ast_after_bridge_goto stuff

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2628/#review8910
-----------------------------------------------------------



/trunk/main/bridging.c
<https://reviewboard.asterisk.org/r/2628/#comment17510>

    Use a scoped channel lock here. That way you don't have to remember to unlock when you return early.



/trunk/main/bridging.c
<https://reviewboard.asterisk.org/r/2628/#comment17511>

    Reduce indentation.
    
    if (!datastore) {
      buffer[0] = '\0';
      return;
    }



/trunk/main/bridging.c
<https://reviewboard.asterisk.org/r/2628/#comment17512>

    It's not clear from this code why we're asserting after handling this condition.
    
    Asserts are a way of saying "huh, this should never happen". While that may be the case here, it's not clear why after_bridge->run_h_exten being true is invalid if after_bridge->context is not specified (and since run_h_exten is handled immediately after)


- Matt Jordan


On June 17, 2013, 7:13 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2628/
> -----------------------------------------------------------
> 
> (Updated June 17, 2013, 7:13 p.m.)
> 
> 
> Review request for Asterisk Developers and rmudgett.
> 
> 
> Bugs: ASTERISK-21875
>     https://issues.asterisk.org/jira/browse/ASTERISK-21875
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Allows the use of CHANNEL(after_bridge_goto) in order to set where to go after a bridge is over or to read the current after bridge goto destination.
> 
> I had to add some checking against autoloop when doing the parseable goto in order to fix where we decrement the priority.
> 
> 
> Diffs
> -----
> 
>   /trunk/funcs/func_channel.c 391852 
>   /trunk/include/asterisk/bridging.h 391852 
>   /trunk/main/bridging.c 391852 
> 
> Diff: https://reviewboard.asterisk.org/r/2628/diff/
> 
> 
> Testing
> -------
> 
> Tested that set(CHANNEL(after_bridge_goto)) would set the parseable goto string and that bridge exits would handle that goto string appropriately
> 
> Checked that reading CHANNEL(after_bridge_goto)) showed the parseable goto string if it was in the after bridge goto datastore and if it wasn't that it would provide the context/extension/priority set in there instead.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130618/df446959/attachment.htm>