[asterisk-dev] [Code Review] 2628: func_channel: Add a function for reading/writing ast_after_bridge_goto stuff

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2628/#review8898
-----------------------------------------------------------



/trunk/funcs/func_channel.c
<https://reviewboard.asterisk.org/r/2628/#comment17469>

    Don't forget to remove these.



/trunk/funcs/func_channel.c
<https://reviewboard.asterisk.org/r/2628/#comment17472>

    If ast_strlen_zero(value) call ast_after_bridge_goto_discard()
    else call ast_after_bridge_set_go_on().



/trunk/main/bridging.c
<https://reviewboard.asterisk.org/r/2628/#comment17471>

    Terminate the buffer in an else clause.  The buffer is not guaranteed to be terminated on entry.


- rmudgett


On June 14, 2013, 10:43 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2628/
> -----------------------------------------------------------
> 
> (Updated June 14, 2013, 10:43 p.m.)
> 
> 
> Review request for Asterisk Developers and rmudgett.
> 
> 
> Bugs: ASTERISK-21875
>     https://issues.asterisk.org/jira/browse/ASTERISK-21875
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Allows the use of CHANNEL(after_bridge_goto) in order to set where to go after a bridge is over or to read the current after bridge goto destination.
> 
> I had to add some checking against autoloop when doing the parseable goto in order to fix where we decrement the priority.
> 
> 
> Diffs
> -----
> 
>   /trunk/funcs/func_channel.c 391852 
>   /trunk/include/asterisk/bridging.h 391852 
>   /trunk/main/bridging.c 391852 
> 
> Diff: https://reviewboard.asterisk.org/r/2628/diff/
> 
> 
> Testing
> -------
> 
> Tested that set(CHANNEL(after_bridge_goto)) would set the parseable goto string and that bridge exits would handle that goto string appropriately
> 
> Checked that reading CHANNEL(after_bridge_goto)) showed the parseable goto string if it was in the after bridge goto datastore and if it wasn't that it would provide the context/extension/priority set in there instead.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130615/6bff0aa3/attachment.htm>