[asterisk-dev] [Code Review] 2625: Properly indicate a failure to open an audio stream in res_agi

[Michael Young]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2625/
-----------------------------------------------------------

Review request for Asterisk Developers.


Bugs: ASTERISK-21903
    https://issues.asterisk.org/jira/browse/ASTERISK-21903


Repository: Asterisk


Description
-------

If there is an error streaming an audio file, the current return status makes it difficult for an AGI script to determine that there was an error with the audio file.

This patches changes the result to return -1 and the function returns RESULT_FAILURE instead of RESULT_SUCCESS.  From looking at other parts of res_agi, this would appear to be the proper way to handle an error.


Diffs
-----

  /branches/1.8/res/res_agi.c 391553 

Diff: https://reviewboard.asterisk.org/r/2625/diff/


Testing
-------

The reporter on the issue has tested out the patch on 1.8 and on 11.  He indicated that it was working for him.


Thanks,

Michael Young

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130614/c1e8d991/attachment.htm>