[asterisk-dev] [Code Review] 2554: Pimp my SIP: alwaysauthreject

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2554/#review8884
-----------------------------------------------------------

Ship it!


Despite the fact that I have raised issues on this review, I'm ticking the "Ship it!" box since the points I bring up are minor and can be fixed easily when merging the code.


team/group/pimp_my_sip/include/asterisk/res_sip.h
<https://reviewboard.asterisk.org/r/2554/#comment17449>

    "finalize" is an odd term for what this function does. When I think of something as being "finalized" I think of that sort of as putting the finishing touches on it. This seems to be more of a cleanup function.



team/group/pimp_my_sip/res/res_sip/config_security.c
<https://reviewboard.asterisk.org/r/2554/#comment17446>

    I think this is leftover debug code.



team/group/pimp_my_sip/res/res_sip/sip_distributor.c
<https://reviewboard.asterisk.org/r/2554/#comment17447>

    The "= NULL" is superfluous since globals are automatically zeroed.



team/group/pimp_my_sip/res/res_sip/sip_distributor.c
<https://reviewboard.asterisk.org/r/2554/#comment17448>

    The "= NULL" is superfluous since globals are automatically zeroed.


- Mark Michelson


On June 4, 2013, 10:31 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2554/
> -----------------------------------------------------------
> 
> (Updated June 4, 2013, 10:31 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21433
>     https://issues.asterisk.org/jira/browse/ASTERISK-21433
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Adds support for 'alwaysauthreject' to the new SIP channel driver.  When the 'alwaysauthreject' option is set to 'yes' (default) and no matching endpoint is found for the incoming request, after challenging, Asterisk will respond with a 401 Unauthorized regardless of the reason it rejects the request.
> 
> These changes also include a new global 'security' configuration section in res_sip.conf that now includes the 'alwaysauthreject' and ACL options.
> 
> 
> Diffs
> -----
> 
>   team/group/pimp_my_sip/include/asterisk/res_sip.h 390437 
>   team/group/pimp_my_sip/res/res_sip.c 390437 
>   team/group/pimp_my_sip/res/res_sip.exports.in 390437 
>   team/group/pimp_my_sip/res/res_sip/config_auth.c 390437 
>   team/group/pimp_my_sip/res/res_sip/config_security.c PRE-CREATION 
>   team/group/pimp_my_sip/res/res_sip/sip_configuration.c 390437 
>   team/group/pimp_my_sip/res/res_sip/sip_distributor.c 390437 
>   team/group/pimp_my_sip/res/res_sip_acl.c 390437 
>   team/group/pimp_my_sip/res/res_sip_authenticator_digest.c 390437 
>   team/group/pimp_my_sip/res/res_sip_outbound_authenticator_digest.c 390437 
> 
> Diff: https://reviewboard.asterisk.org/r/2554/diff/
> 
> 
> Testing
> -------
> 
> Attempted to connect to an unknown endpoint in Asterisk and observed that it responded appropriately and with a correct 401 when 'alwaysauthreject' was enabled.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130613/b4ef8255/attachment.htm>