[asterisk-dev] [Code Review] 2616: Features configuration documentation

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2616/#review8879
-----------------------------------------------------------



/trunk/main/features_config.c
<https://reviewboard.asterisk.org/r/2616/#comment17426>

    You need to specify the yes behavior since you have specified the no behavior.



/trunk/main/features_config.c
<https://reviewboard.asterisk.org/r/2616/#comment17425>

    You've been blobbed.



/trunk/main/features_config.c
<https://reviewboard.asterisk.org/r/2616/#comment17427>

    These sounds are normally played to the transferrer in an attended transfer.
    
    The xfersound is also played to the transfer target and AMI bridge channels.



/trunk/main/features_config.c
<https://reviewboard.asterisk.org/r/2616/#comment17428>

    Aborting a transfer results in the transferrer rejoining the bridge with the transferee as if the transfer attempt did not happen.



/trunk/main/features_config.c
<https://reviewboard.asterisk.org/r/2616/#comment17429>

    Transferee not be plural.



/trunk/main/features_config.c
<https://reviewboard.asterisk.org/r/2616/#comment17430>

    s/transferees/transferee/



/trunk/main/features_config.c
<https://reviewboard.asterisk.org/r/2616/#comment17431>

    s/monitoring of a/monitoring a/



/trunk/main/features_config.c
<https://reviewboard.asterisk.org/r/2616/#comment17432>

    s/monitoring of a/monitoring a/
    
    Also you may want to group automixmonr and automon together rather than separating them by parkcall.



/trunk/main/features_config.c
<https://reviewboard.asterisk.org/r/2616/#comment17433>

    or featuregroup names.



/trunk/main/features_config.c
<https://reviewboard.asterisk.org/r/2616/#comment17434>

    Don't document the caller/callee historical values of who to invoke the feature on.  Those names aren't very accurate which is why self/peer is now used.


- rmudgett


On June 12, 2013, 1:15 a.m., Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2616/
> -----------------------------------------------------------
> 
> (Updated June 12, 2013, 1:15 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This adds XML documentation for features configuration. This is mostly straightforward, but there are a few points to make:
> 
> * I've changed the appdocsxml.dtd to allow ref elements to refer to configOption elements.
> * Applicationmap items have a syntax section, but this does not print to the CLI when the configuration help is shown. It appears that that code in xmldoc.c specifically ignores syntax sections in configOption elements. This should likely be changed, but it should be done as a separate change.
> * Applicationmap items and featuregroup items can take any name as the name of the option. I followed the example of ConfBridge and used the acceptable regex as the name of the configuration option. This results in the somewhat clunky CLI command "config show help features applicationmap ^.*$" . Unfortunately, there's not really a better option as far as I can tell.
> 
> 
> Diffs
> -----
> 
>   /trunk/doc/appdocsxml.dtd 391478 
>   /trunk/main/features_config.c 391478 
> 
> Diff: https://reviewboard.asterisk.org/r/2616/diff/
> 
> 
> Testing
> -------
> 
> Docs validate properly and the CLI commands to show the help work as expected.
> 
> 
> Thanks,
> 
> Mark Michelson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130612/987ea076/attachment-0001.htm>