[asterisk-dev] [Code Review] 2613: IAX2: Transfer Reject: Lock bridgecallno before touching it, refactor

[Alec Davis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2613/#review8876
-----------------------------------------------------------

Ship it!


discussed this on IRC with matt.

Using reviewboard to document this.

- Alec Davis


On June 11, 2013, 8:01 a.m., Alec Davis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2613/
> -----------------------------------------------------------
> 
> (Updated June 11, 2013, 8:01 a.m.)
> 
> 
> Review request for Asterisk Developers and Matt Jordan.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> 1). When touching the bridgecallno, we need to lock it.
> 
> 2). Remove magic number '0' and replace with TRANSFER_NONE.
> 
> 3). Exit early if no bridgecallno.
> 
> 4). Reduce indentation.
> 
> 
> Diffs
> -----
> 
>   branches/1.8/channels/chan_iax2.c 391332 
> 
> Diff: https://reviewboard.asterisk.org/r/2613/diff/
> 
> 
> Testing
> -------
> 
> Test calls to the queue app up the trunk, which inturn make a call back down same trunk.
> These queue calls don't have have a bridgecallno.
> Verified that 'unable to transfer' was still emiited.  
> 
> 
> Thanks,
> 
> Alec Davis
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130611/4a1f9cc0/attachment.htm>