[asterisk-dev] [Code Review] 2579: Add vtable and methods for to_json and to_ami for Stasis messages

[David Lee]

> On June 5, 2013, 8:18 a.m., opticron wrote:
> > /trunk/include/asterisk/stasis.h, line 188
> > <https://reviewboard.asterisk.org/r/2579/diff/2/?file=39092#file39092line188>
> >
> >     This conflicts with earlier documentation.

No. The earlier comment says that NULL may be returned to indicate that it's not supported. It may also be returned to indicate an error.


> On June 5, 2013, 8:18 a.m., opticron wrote:
> > /trunk/include/asterisk/stasis.h, line 189
> > <https://reviewboard.asterisk.org/r/2579/diff/2/?file=39092#file39092line189>
> >
> >     ast_json_null() could be returned in this case (watch out for the trickle-down if you do).
> >     
> >     support -> supported

Not sure how useful returning an ast_json_null() would be, so I'm leaving it as is.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2579/#review8798
-----------------------------------------------------------


On June 4, 2013, 1:09 p.m., David Lee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2579/
> -----------------------------------------------------------
> 
> (Updated June 4, 2013, 1:09 p.m.)
> 
> 
> Review request for Asterisk Developers, Matt Jordan and Jason Parker.
> 
> 
> Bugs: ASTERISK-21817
>     https://issues.asterisk.org/jira/browse/ASTERISK-21817
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> When a Stasis message type is defined in a loadable module, handling
> those messages for AMI and res_stasis events can be cumbersome.
> 
> This patch adds a vtable to stasis_message_type, with to_ami and
> to_json virtual functions. These allow messages to be handled
> abstractly without putting module-specific code in core.
> 
> As an example, the VarSet AMI event was refactored to use the to_ami
> virtual function.
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/confbridge/confbridge_manager.c 390151 
>   /trunk/include/asterisk/stasis.h 390151 
>   /trunk/main/manager.c 390151 
>   /trunk/main/manager_channels.c 390151 
>   /trunk/main/parking.c 390151 
>   /trunk/main/stasis_channels.c 390151 
>   /trunk/main/stasis_message.c 390151 
>   /trunk/tests/test_stasis.c 390151 
>   /trunk/tests/test_stasis_channels.c 390151 
> 
> Diff: https://reviewboard.asterisk.org/r/2579/diff/
> 
> 
> Testing
> -------
> 
> Unit tests.
> 
> Verified that the VarSet event still looked the way it ought to.
> 
> 
> Thanks,
> 
> David Lee
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130610/14f1a979/attachment.htm>