[asterisk-dev] [Code Review] 2570: Finish Gulp Connected Line Support

svnbot reviewboard at asterisk.org
Mon Jun 10 07:02:52 CDT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2570/
-----------------------------------------------------------

(Updated June 10, 2013, 7:02 a.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers.


Changes
-------

Committed in revision 391193


Bugs: ASTERISK-21258
    https://issues.asterisk.org/jira/browse/ASTERISK-21258


Repository: Asterisk


Description
-------

This change implements handling of the connected line indication. This entails sending responses if possible, or sending requests (INVITE / UPDATE). The existing callerid code handles adding the information (and it does it marvelously).


Diffs
-----

  /team/group/pimp_my_sip/channels/chan_gulp.c 390033 
  /team/group/pimp_my_sip/include/asterisk/res_sip.h 390033 
  /team/group/pimp_my_sip/res/res_sip.c 390033 
  /team/group/pimp_my_sip/res/res_sip/sip_configuration.c 390033 
  /team/group/pimp_my_sip/res/res_sip_caller_id.c 390033 

Diff: https://reviewboard.asterisk.org/r/2570/diff/


Testing
-------

Tested various scenarios to ensure that the problem information is sent.


Thanks,

Joshua Colp

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130610/77449ecd/attachment.htm>


More information about the asterisk-dev mailing list