[asterisk-dev] [Code Review] 2602: IAX2: refactor nativebridge transfer.

[Alec Davis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2602/
-----------------------------------------------------------

(Updated June 9, 2013, 12:49 a.m.)


Review request for Asterisk Developers.


Changes
-------

After seeing revision 2 side by side, it didn't achieve exactly the same.

revision 3 does.

What can now easily be seen, is that it's possible that both sides don't match their transfer types, one side can be MEDIA only, the other can be SIGNALLING.

Based on the last leg to become ready, if the last leg is TRANSFER_MREADY then a MEDIA only transfer will attempt to happen.
But is that right? hence the XXX note.


Repository: Asterisk


Description
-------

remove triple checking of iaxs[fr->callno]->transferring

reduce indentation.

I've done this as 2 step, so that reviewers are confident nothing breaks.


Diffs (updated)
-----

  branches/11/channels/chan_iax2.c 391036 

Diff: https://reviewboard.asterisk.org/r/2602/diff/


Testing
-------


Thanks,

Alec Davis

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130609/0aa27cbe/attachment.htm>