[asterisk-dev] [Code Review] 2507: Add support for indexing installed sounds and for Stasis-HTTP sounds queries

[Alec Davis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2507/#review8868
-----------------------------------------------------------



trunk/res/stasis_http/resource_sounds.c
<https://reviewboard.asterisk.org/r/2507/#comment17417>

    exit early on error;
    
    if (!sound_blob) {
       response_error( ... 404 ..
       return;
    }
    ...response_ok( ...


- Alec Davis


On June 4, 2013, 2:20 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2507/
> -----------------------------------------------------------
> 
> (Updated June 4, 2013, 2:20 p.m.)
> 
> 
> Review request for Asterisk Developers and David Lee.
> 
> 
> Bugs: ASTERISK-21584 and ASTERISK-21585
>     https://issues.asterisk.org/jira/browse/ASTERISK-21584
>     https://issues.asterisk.org/jira/browse/ASTERISK-21585
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This adds support for stasis/sounds and stasis/sounds/{ID} queries via the Stasis-HTTP interface.
> 
> The following changes have been made to accomplish this:
> * A modular indexer was created for local media.
> * A new function to get an ast_format associated with a file extension was added.  
> * Modifications were made to the built-in HTTP server so that URI decoding could be deferred to the URI handler when necessary.
> * The Stasis-HTTP sounds JSON documentation was modified to handle cases where multiple languages are installed in different formats.
> * Register and Unregister events for formats were added to the system topic.
> 
> 
> Diffs
> -----
> 
>   trunk/include/asterisk/_private.h 390391 
>   trunk/include/asterisk/file.h 390391 
>   trunk/include/asterisk/format.h 390391 
>   trunk/include/asterisk/http.h 390391 
>   trunk/include/asterisk/media_index.h PRE-CREATION 
>   trunk/include/asterisk/sounds_index.h PRE-CREATION 
>   trunk/main/asterisk.c 390391 
>   trunk/main/file.c 390391 
>   trunk/main/http.c 390391 
>   trunk/main/media_index.c PRE-CREATION 
>   trunk/main/sounds_index.c PRE-CREATION 
>   trunk/res/res_stasis_http.c 390391 
>   trunk/res/stasis_http/resource_sounds.c 390391 
>   trunk/rest-api/api-docs/sounds.json 390391 
> 
> Diff: https://reviewboard.asterisk.org/r/2507/diff/
> 
> 
> Testing
> -------
> 
> Tested using a browser and HTTP GET requests using the Stasis-HTTP API.  Currently contemplating how to create automated tests.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130608/c47accd0/attachment-0001.htm>