[asterisk-dev] [Code Review] 2590: chan_pjsip: Security Events

[Joshua Colp]

> On June 7, 2013, 12:39 a.m., Mark Michelson wrote:
> > /team/group/pimp_my_sip/res/res_sip_registrar.c, line 269
> > <https://reviewboard.asterisk.org/r/2590/diff/1/?file=39088#file39088line269>
> >
> >     Seems like a good fit for an ast_security_event_session_limit
> 
> Mark Michelson wrote:
>     Actually maybe not. I was interpreting "session limit" to be any exceeded limit, but thinking about it more, that really doesn't fit well with registration contact limits.

Ditto.


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2590/#review8854
-----------------------------------------------------------


On June 4, 2013, 3:55 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2590/
> -----------------------------------------------------------
> 
> (Updated June 4, 2013, 3:55 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This change causes chan_pjsip to emit security events during various scenarios.
> 
> 
> Diffs
> -----
> 
>   /team/group/pimp_my_sip/res/res_sip/security_events.c PRE-CREATION 
>   /team/group/pimp_my_sip/res/res_sip.exports.in 390396 
>   /team/group/pimp_my_sip/include/asterisk/res_sip.h 390396 
>   /team/group/pimp_my_sip/res/res_sip/sip_distributor.c 390396 
>   /team/group/pimp_my_sip/res/res_sip_registrar.c 390396 
> 
> Diff: https://reviewboard.asterisk.org/r/2590/diff/
> 
> 
> Testing
> -------
> 
> Ran into the various situations (by purposely modifying the code or actually doing it) and confirmed the security event framework was getting called with proper information.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130607/ede96fa8/attachment.htm>