[asterisk-dev] [Code Review] 2566: autoservice_run ast_frfree missing when already out of mem

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2566/#review8841
-----------------------------------------------------------



/trunk/main/autoservice.c
<https://reviewboard.asterisk.org/r/2566/#comment17386>

    No, we should never reach this point.
    
    The ast_waitfor_n() call only will read frames from the channels' file descriptors. If ast_waitfor_n() returns non-NULL, then one of the channels in the mons array must have triggered the return. 
    
    If this point is reached, I suggest complaining very loudly and asserting in addition to what you have here, because something has gone wrong.


- Mark Michelson


On May 25, 2013, 1:30 p.m., wdoekes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2566/
> -----------------------------------------------------------
> 
> (Updated May 25, 2013, 1:30 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Hi, I'm trying to find the cause of an issue I encountered with a terrible lot of duplicated fax frames.
> 
> While browsing the code, I found the following hard to read code. It looks to me like there is a missing ast_frfree() in this off-nominal path when we're out of mem.
> 
> 
> Diffs
> -----
> 
>   /trunk/main/autoservice.c 389769 
> 
> Diff: https://reviewboard.asterisk.org/r/2566/diff/
> 
> 
> Testing
> -------
> 
> None whatsoever.
> 
> 
> Thanks,
> 
> wdoekes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130606/7eac400c/attachment.htm>