[asterisk-dev] [Code Review] 2598: chan_pjsip: Stateful Contact Expiration

[Joshua Colp]

> On June 6, 2013, 6:39 p.m., opticron wrote:
> > /team/group/pimp_my_sip/res/res_sip_registrar_expire.c, lines 76-86
> > <https://reviewboard.asterisk.org/r/2598/diff/1/?file=39182#file39182line76>
> >
> >     This seems to be missing an unlink from the contact_autoexpire container.

Using ast_sorcery_delete will cause the observer to get called again, which will perform the unlinking.


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2598/#review8838
-----------------------------------------------------------


On June 5, 2013, 7:23 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2598/
> -----------------------------------------------------------
> 
> (Updated June 5, 2013, 7:23 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This change adds a stand-alone module which uses sorcery observers to delete contacts when they should expire, unless updated. This will allow persistent endpoint state to reflect reality.
> 
> 
> Diffs
> -----
> 
>   /team/group/pimp_my_sip/res/res_sip_registrar_expire.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/2598/diff/
> 
> 
> Testing
> -------
> 
> Tweaked the code to explicitly expire contacts after 5 seconds, confirmed it happens and that structures get destroyed as expected.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130606/80f7abc1/attachment.htm>