[asterisk-dev] [Code Review] 2597: Implement POST to channels, to originate a call.

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2597/#review8837
-----------------------------------------------------------



/trunk/res/stasis_http/resource_channels.c
<https://reviewboard.asterisk.org/r/2597/#comment17378>

    It appears there is no way for someone to indicate they wish to have an unlimited timeout. Is that desired?



/trunk/res/stasis_http/resource_channels.c
<https://reviewboard.asterisk.org/r/2597/#comment17375>

    You should only call this if ast_is_shrinkable_phonenumber() returns true.



/trunk/res/stasis_http/resource_channels.c
<https://reviewboard.asterisk.org/r/2597/#comment17376>

    What's the point of these two if blocks? It appears that ast_pbx_outgoing_app() will treat a NULL or zero-length caller ID the same.


- Mark Michelson


On June 6, 2013, 4:23 p.m., Jason Parker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2597/
> -----------------------------------------------------------
> 
> (Updated June 6, 2013, 4:23 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21617
>     https://issues.asterisk.org/jira/browse/ASTERISK-21617
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This doesn't support CallerID or codec selection, like the manager action.  Should it?
> 
> 
> Diffs
> -----
> 
>   /trunk/res/res_stasis_http_channels.c 390668 
>   /trunk/res/stasis_http/resource_channels.h 390668 
>   /trunk/res/stasis_http/resource_channels.c 390668 
>   /trunk/res/stasis_json/resource_channels.h 390668 
>   /trunk/rest-api/api-docs/channels.json 390668 
> 
> Diff: https://reviewboard.asterisk.org/r/2597/diff/
> 
> 
> Testing
> -------
> 
> Calls get made to the location you specify.  The call gets put into the Stasis application when it gets answered.
> 
> 
> Thanks,
> 
> Jason Parker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130606/b5b84d84/attachment.htm>