[asterisk-dev] [Code Review] 2596: Rework stasis cache clear events

[David Lee]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2596/#review8834
-----------------------------------------------------------

Ship it!


- David Lee


On June 6, 2013, 12:56 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2596/
> -----------------------------------------------------------
> 
> (Updated June 6, 2013, 12:56 p.m.)
> 
> 
> Review request for Asterisk Developers and David Lee.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This reworks the stasis cache clear mechanism such that an actual snapshot message is published inside of the cache clear message instead of the stasis_cache_clear structure (the ID and message type) which has been removed.  This allows multiple caches to consume the same clear message and avoids the problems of needing to clear unknown secondary caches which may be keyed on different parts of the snapshot.
> 
> This also resolves an issue where a channel snapshot could be cleared from the channel snapshot cache multiple times if multiple threads called ast_hangup on the channel at the same time.
> 
> This also resolves an issue where an endpoint snapshot was published after it was cleared from the cache, thus repopulating it in the cache.
> 
> 
> Diffs
> -----
> 
>   trunk/include/asterisk/stasis.h 390501 
>   trunk/main/bridging.c 390501 
>   trunk/main/channel.c 390501 
>   trunk/main/endpoints.c 390501 
>   trunk/main/stasis_cache.c 390501 
>   trunk/main/stasis_channels.c 390501 
>   trunk/tests/test_stasis.c 390501 
> 
> Diff: https://reviewboard.asterisk.org/r/2596/diff/
> 
> 
> Testing
> -------
> 
> Ran test_stasis, test_stasis_channels, and test_stasis_endpoints with no error messages.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130606/222bc59b/attachment.htm>