[asterisk-dev] [Code Review] 2591: Add a _remove method for routes on a message_router.

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2591/#review8809
-----------------------------------------------------------



/trunk/main/stasis_message_router.c
<https://reviewboard.asterisk.org/r/2591/#comment17335>

    I'd change this to an ao2_find with OBJ_UNLINK.


- Joshua Colp


On June 5, 2013, 3:37 p.m., Jason Parker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2591/
> -----------------------------------------------------------
> 
> (Updated June 5, 2013, 3:37 p.m.)
> 
> 
> Review request for Asterisk Developers and David Lee.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Requested on review 2586.
> 
> Convert router routes to ao2_containers and add a way of removing them.
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/stasis_message_router.h 390386 
>   /trunk/main/stasis_message_router.c 390386 
> 
> Diff: https://reviewboard.asterisk.org/r/2591/diff/
> 
> 
> Testing
> -------
> 
> Stuff didn't crash when I unloaded my module that removes routes.  Messages still got routed through AMI.
> 
> 
> Thanks,
> 
> Jason Parker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130605/36a2a60b/attachment.htm>