[asterisk-dev] [Code Review] 2545: res_parking: Generate extensions when parkext is set for a parking lot. Generate extension to dial parker on parked call timeout.

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2545/
-----------------------------------------------------------

(Updated June 5, 2013, 7:40 p.m.)


Review request for Asterisk Developers, Matt Jordan and rmudgett.


Changes
-------

1) Parking space extension+context overlaps are now forbidden when making extensions even in parkext_exclusive=no mode. This couldn't be reconciled with hints without changing the hint device state format. This means parkext_exclusive now only affects the extension indicated by parkext.

2) added parking_devicestate.c which has a device state provider as well as a function for setting device state. The device state provider function may be somewhat slower than what it replaces since it has to find which lot owns a parked call extension and then determine if a call is parked in that position. O(n1) + O(n2) where n1 = number of lots and n2 = number of parked users currently in the lot picked from n1. Previously it just searched for the existence of the extension which is no longer possible since extensions are created on configuration rather than when parking. Actually it was probably never really correct since people could still just write extensions wherever, but it is what it is.


Bugs: ASTERISK-21645
    https://issues.asterisk.org/jira/browse/ASTERISK-21645


Repository: Asterisk


Description
-------

Extension generation and removal for:
Park a call to the parkext in the parking context
Retrieve parked calls from the space numbers in the parking context
Hints for ParkedCall extensions

Extension generation (but no removal yet) for:
Dial the peer which parked the call on parking timeout in the park-dial context

Extension removal for the park-dial extensions will eventually be handled when reloads are implemented. Since they can't reliably be said to belong to
the parking lot, they are registered to the base registrar for the parking system instead.

Applying bridge features in the way features.c did (as arguments to dial) is no longer necessary on account of how features are handled now.

Each parking lot has its own registrar which is 'res_parking/<parking lot name>'
The registrar used for non-lot-specific extensions is just 'res_parking'

When a parking lot is destroyed or reloaded, all of its registered extensions are flushed and rebuilt.

Note: ParkedCall extensions no longer belong to the parked user involved with them unlike how old parking works. This means that if a parking lot is reloaded and the new configuration specifies that the slot the old call was parked at no longer exists, the extension to retrieve that call will go away even though the call is still parked there. This will resolve itself when the parked call times out (provided timeout hasn't been disabled), and manually created ParkedCall extensions can still retrieve that call if the parking space option isn't provided.


Diffs (updated)
-----

  /team/group/bridge_construction/CHANGES 390539 
  /team/group/bridge_construction/include/asterisk/pbx.h 390539 
  /team/group/bridge_construction/main/pbx.c 390539 
  /team/group/bridge_construction/res/parking/parking_bridge.c 390539 
  /team/group/bridge_construction/res/parking/parking_bridge_features.c 390539 
  /team/group/bridge_construction/res/parking/parking_controller.c 390539 
  /team/group/bridge_construction/res/parking/parking_devicestate.c PRE-CREATION 
  /team/group/bridge_construction/res/parking/res_parking.h 390539 
  /team/group/bridge_construction/res/res_parking.c 390539 

Diff: https://reviewboard.asterisk.org/r/2545/diff/


Testing
-------

Checked that extensions are generated and destroyed for Park and ParkedCall as expected with multiple parking lots.
Overlaps are currently allowed. If two parking lots occupy the same space and parkext exclusive is in use, it's possible for one parking lot's extensions to be overwritten in favor of another. When parking lot extensions are overwritten by other parking lot extensions, warnings are issued.
Checked that extensions are generated and appropriately called in park-dial when a parked call times out.
Checked that the timeout is set to the parking lot's parkdialtimeout value.


Thanks,

jrose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130605/078aeef5/attachment-0001.htm>