[asterisk-dev] [Code Review] 2595: testsuite: Make the directed pickup test work with Asterisk 12 bridging events

[jrose]

> On June 5, 2013, 1:48 p.m., opticron wrote:
> > /asterisk/trunk/tests/apps/directed_pickup/run-test, lines 53-56
> > <https://reviewboard.asterisk.org/r/2595/diff/1/?file=39144#file39144line53>
> >
> >     This is dead code since self.bridge is never set to anything other that None during init.

Oops. Forgot to set it. Fixed with an else clause:

        if self.bridge is not None:
            if bridge != self.bridge:
                LOGGER.error("Channel: '%s' entered bridge '%s', but was expected to enter the '%s' bridge with '%s'" % (channel, bridge, other_channel, self.bridge))
                self.set_passed(False)
        else:
            self.bridge = bridge


- jrose


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2595/#review8799
-----------------------------------------------------------


On June 4, 2013, 11:06 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2595/
> -----------------------------------------------------------
> 
> (Updated June 4, 2013, 11:06 p.m.)
> 
> 
> Review request for Asterisk Developers, kmoore and Matt Jordan.
> 
> 
> Bugs: ASTERISK-21544
>     https://issues.asterisk.org/jira/browse/ASTERISK-21544
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> Because this test was using "Bridge" events which are no longer issued, I made it so that it does the following when Asterisk 12 mode is used:
> 
> Watch for BridgeEnter events
> 
> Make sure both channels expected generate these events
> Make sure both of these events point to the same bridge
> 
> That last bit is something I'm going to go ahead and add to https://reviewboard.asterisk.org/r/2592/ as well.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/apps/directed_pickup/run-test 3820 
> 
> Diff: https://reviewboard.asterisk.org/r/2595/diff/
> 
> 
> Testing
> -------
> 
> ran the test and made sure I could make it consistently work.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130605/73494c0c/attachment-0001.htm>