[asterisk-dev] [Code Review] 2584: New SIP Channel Driver - SIP Qualify Support

[Kevin Harwell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2584/
-----------------------------------------------------------

(Updated June 4, 2013, 9:16 p.m.)


Review request for Asterisk Developers.


Changes
-------

Addressed review issues.


Bugs: ASTERISK-21499
    https://issues.asterisk.org/jira/browse/ASTERISK-21499


Repository: Asterisk


Description
-------

Completed the work that had been started for SIP qualify support in the new channel driver.  Qualify requests are now sent for every contact associated with an endpoint.  When a contact is registered a check is done to make sure it is available and the round trip time is stored for reference.  The contact continues to be checked at a specified interval (qualify_frequency - now set on the AOR) until it is removed.

A CLI command ("sip qualify <endpoint>") is also available that when issued will send qualifies for all contacts on the given endpoint.  Also added CLI command "sip show endpoint <endpoint>" that will show all the contacts and their status for the given endpoint.


Diffs (updated)
-----

  /team/group/pimp_my_sip/include/asterisk/res_sip.h 390435 
  /team/group/pimp_my_sip/res/res_sip.c 390435 
  /team/group/pimp_my_sip/res/res_sip/location.c 390435 
  /team/group/pimp_my_sip/res/res_sip/sip_configuration.c 390435 
  /team/group/pimp_my_sip/res/res_sip/sip_options.c 390435 
  /team/group/pimp_my_sip/res/res_sip_registrar.c 390435 

Diff: https://reviewboard.asterisk.org/r/2584/diff/


Testing
-------

Manually tested by registering contacts and making sure the qualify requests were sent out and scheduled.


Thanks,

Kevin Harwell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130604/dfb1648c/attachment.htm>