[asterisk-dev] [Code Review] 2587: Refactor res_agi AMI events into stasis.

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2587/#review8796
-----------------------------------------------------------



/trunk/res/res_agi.c
<https://reviewboard.asterisk.org/r/2587/#comment17288>

    All of the new manager event XML here should transclude the standard set of channel blob parameters.



/trunk/res/res_agi.c
<https://reviewboard.asterisk.org/r/2587/#comment17286>

    Since you're pulling all of the parameters in the AGIExecStart event, you can use a single xi:include and just omit the [@name=...].



/trunk/res/res_agi.c
<https://reviewboard.asterisk.org/r/2587/#comment17289>

    This is essentially a duplicate of ast_channel_publish_blob in stasis_channels.h.



/trunk/res/res_agi.c
<https://reviewboard.asterisk.org/r/2587/#comment17290>

    execblob needs to be checked for NULL before you do this.



/trunk/res/res_agi.c
<https://reviewboard.asterisk.org/r/2587/#comment17291>

    Now that the event between the switch statements is gone, they should probably be merged.  It also appears that there are now some code paths that will no longer emit an AMI message.



/trunk/res/res_agi.c
<https://reviewboard.asterisk.org/r/2587/#comment17292>

    This probably needs some work from review 2591 when it goes in, a BUGBUG would be appropriate for now.


- opticron


On June 3, 2013, 2:08 p.m., Jason Parker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2587/
> -----------------------------------------------------------
> 
> (Updated June 3, 2013, 2:08 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21470
>     https://issues.asterisk.org/jira/browse/ASTERISK-21470
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Move res_agi AMI events to stasis.
> 
> Also removes the SubEvent field from all of the events, splitting them into their own unique events.
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 390381 
>   /trunk/res/res_agi.c 390381 
> 
> Diff: https://reviewboard.asterisk.org/r/2587/diff/
> 
> 
> Testing
> -------
> 
> All of the events come out when they're supposed to, with the same data as before (plus channel stuffs, minus SubEvent fields).
> 
> 
> Thanks,
> 
> Jason Parker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130604/d24d71c5/attachment-0001.htm>