[asterisk-dev] [Code Review] 2590: chan_pjsip: Security Events

[Michael Young]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2590/#review8789
-----------------------------------------------------------


Looks good from my perspective.  Just the one comment below.


/team/group/pimp_my_sip/res/res_sip/security_events.c
<https://reviewboard.asterisk.org/r/2590/#comment17278>

    Curious about this... besides the fact that the red blob stood out.
    
    To match chan_sip events, should we put the challenge (nonce) that we sent in here so that we can compare it to the challenge received (nonce) from the endpoint?  That might help a consumer of the logs to determine if a stale nonce is being used or not by the endpoint.
    
    Just a thought I wanted to throw out there.


- Michael Young


On June 4, 2013, 11:55 a.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2590/
> -----------------------------------------------------------
> 
> (Updated June 4, 2013, 11:55 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This change causes chan_pjsip to emit security events during various scenarios.
> 
> 
> Diffs
> -----
> 
>   /team/group/pimp_my_sip/res/res_sip/security_events.c PRE-CREATION 
>   /team/group/pimp_my_sip/res/res_sip.exports.in 390396 
>   /team/group/pimp_my_sip/include/asterisk/res_sip.h 390396 
>   /team/group/pimp_my_sip/res/res_sip/sip_distributor.c 390396 
>   /team/group/pimp_my_sip/res/res_sip_registrar.c 390396 
> 
> Diff: https://reviewboard.asterisk.org/r/2590/diff/
> 
> 
> Testing
> -------
> 
> Ran into the various situations (by purposely modifying the code or actually doing it) and confirmed the security event framework was getting called with proper information.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130604/2bc217aa/attachment.htm>