[asterisk-dev] [Code Review] 2589: New SIP Channel Driver - add call pickup group configuration options

[Kevin Harwell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2589/
-----------------------------------------------------------

(Updated June 4, 2013, 2:39 p.m.)


Review request for Asterisk Developers.


Changes
-------

Return an error in the call group configuration handlers when an invalid variable is given.


Bugs: ASTERISK-21505
    https://issues.asterisk.org/jira/browse/ASTERISK-21505


Repository: Asterisk


Description
-------

Added the ability to configure pick up groups automatically on a channel created for a chan_gulp endpoint. This includes:
callgroup, pickupgroup, namedcallgroup, namedpickupgroup.


Diffs (updated)
-----

  team/group/pimp_my_sip/channels/chan_gulp.c 390395 
  team/group/pimp_my_sip/include/asterisk/res_sip.h 390395 
  team/group/pimp_my_sip/res/res_sip.c 390395 
  team/group/pimp_my_sip/res/res_sip/sip_configuration.c 390395 

Diff: https://reviewboard.asterisk.org/r/2589/diff/


Testing
-------

Manually tested: Configured options on endpoints, called appropriate endpoint, and then picked up call from specified grouped endpoint.


Thanks,

Kevin Harwell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130604/4088a559/attachment.htm>