[asterisk-dev] [Code Review] 2589: New SIP Channel Driver - add call pickup group configuration options

[Kevin Harwell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2589/
-----------------------------------------------------------

(Updated June 3, 2013, 11:13 p.m.)


Review request for Asterisk Developers.


Changes
-------

Changed configuration option handler to key off variable name instead of flag specifier.


Bugs: ASTERISK-21505
    https://issues.asterisk.org/jira/browse/ASTERISK-21505


Repository: Asterisk


Description
-------

Added the ability to configure pick up groups automatically on a channel created for a chan_gulp endpoint. This includes:
callgroup, pickupgroup, namedcallgroup, namedpickupgroup.


Diffs (updated)
-----

  team/group/pimp_my_sip/include/asterisk/res_sip.h 390389 
  team/group/pimp_my_sip/res/res_sip.c 390389 
  team/group/pimp_my_sip/res/res_sip.exports.in 390389 
  team/group/pimp_my_sip/res/res_sip/config_auth.c 390389 
  team/group/pimp_my_sip/res/res_sip/config_security.c PRE-CREATION 
  team/group/pimp_my_sip/res/res_sip/sip_configuration.c 390389 
  team/group/pimp_my_sip/res/res_sip/sip_distributor.c 390389 
  team/group/pimp_my_sip/res/res_sip_acl.c 390389 
  team/group/pimp_my_sip/res/res_sip_authenticator_digest.c 390389 
  team/group/pimp_my_sip/res/res_sip_outbound_authenticator_digest.c 390389 

Diff: https://reviewboard.asterisk.org/r/2589/diff/


Testing
-------

Manually tested: Configured options on endpoints, called appropriate endpoint, and then picked up call from specified grouped endpoint.


Thanks,

Kevin Harwell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130603/e6739a2c/attachment.htm>