[asterisk-dev] [Code Review] 2711: bridge_holding: Fix indication order and add the ability to suspend and unsuspend entertainment audio when something interrupts it.

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2711/#review9267
-----------------------------------------------------------

Ship it!


Ship It!

- Matt Jordan


On July 29, 2013, 5:38 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2711/
> -----------------------------------------------------------
> 
> (Updated July 29, 2013, 5:38 p.m.)
> 
> 
> Review request for Asterisk Developers, Matt Jordan, Mark Michelson, and rmudgett.
> 
> 
> Bugs: ASTERISK-22006
>     https://issues.asterisk.org/jira/browse/ASTERISK-22006
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> While the issue report suggests adding a new technology callback specific to playfile I decided this was largely unnecessary since SUSPEND and UNSUSPEND were already in use when doing the bridge playfile operations. This patch adds suspend and unsuspend functions to the holding bridge which will stop and resume entertainment under certain conditions (we only resume entertainment if an announcer isn't present). In addition, having noticed that there was a race condition for indications brought on by attended transfers, the ringing indication no longer pushes the frame immediately on entry to the bridge. Instead it is queued. This ensures that ringing will be the last frame issued when entering the bridge, so the ringing entertainment will not get interrupted.
> 
> 
> Diffs
> -----
> 
>   /trunk/bridges/bridge_holding.c 395574 
> 
> Diff: https://reviewboard.asterisk.org/r/2711/diff/
> 
> 
> Testing
> -------
> 
> Tested attended transfers to ringing park applications to make sure the ringing indication would work properly now. Used a hacked bridge playfile condition on participants in a holding bridge in order to make sure the suspend and suspend functions worked properly.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130801/610fd369/attachment-0001.htm>